Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret passed as a param risks MITM attack #239

Open
posthello-code opened this issue Mar 11, 2022 · 3 comments
Open

Secret passed as a param risks MITM attack #239

posthello-code opened this issue Mar 11, 2022 · 3 comments

Comments

@posthello-code
Copy link

Putting sensitive information in the url (such as https://listed.to/authors/{id}/settings/?secret={secret}) is not a recommended practice since this information is plainly visible in server logs and could be intercepted by a third party.

This risk would be mitigated if the secret token was a one time use, or could be revoked by the associated standard notes account in case of compromise, but that doesn't appear to be possible.

@moughxyz
Copy link
Member

Indeed, something we hope to improve upon. Listed runs on pretty legacy Rails and has not been brought up to date with the rest of our infrastructure, but we're slowly inching our way there. Likely we cannot get around passing it in the URL for GET requests like opening up the user Settings page but we can explore short-lived tokens.

@Lissy93
Copy link

Lissy93 commented Nov 13, 2022

Any update on this? I feel like it's a pretty major security issue, since with that token, all private posts can be found, posts can be edited/ deleted and settings modified. Possibly an alternative could be to use Standard Notes auth?

What's the plan for the updated version of Listed (tech stack, timelines, etc)? I would definitely be happy to help out with any dev tasks if needed 💕 I find that it's a really useful tool, and I would love for it to be more actively maintained.

@moughxyz
Copy link
Member

No major upgrades or architectural changes planned for Listed right now, as much as we love the service. We don't have the capacity to undertake any big architectural refactors for it right now, as our present focus is our main app stack.

Although ephemeral tokens would be an improvement, the security concern here is in my opinion theoretical and not too practical. The only parties that could see a query param in an https request is you and us. On our end we're careful not to log this parameter as it passes through our infrastructure stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants