Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SVGs for visual tests after new ggplot2 release #310

Open
jgabry opened this issue Jan 17, 2024 · 0 comments
Open

Update SVGs for visual tests after new ggplot2 release #310

jgabry opened this issue Jan 17, 2024 · 0 comments
Labels

Comments

@jgabry
Copy link
Member

jgabry commented Jan 17, 2024

The release candidate for ggplot2 available via remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592")) breaks some of the visual tests due to very tiny differences in the SVGs. Once ggplot2 is released (scheduled for Feb 12), remember to run testthat locally and then use testthat::snapshot_review to update the SVGs. Until the ggplot2 release I will keep the SVGs compatible with the current CRAN version of ggplot2.

@jgabry jgabry added the tests label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant