Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Make bayesplot_grid objects a ggplot object #268

Open
billdenney opened this issue May 21, 2021 · 1 comment · May be fixed by #270
Open

Feature Request: Make bayesplot_grid objects a ggplot object #268

billdenney opened this issue May 21, 2021 · 1 comment · May be fixed by #270

Comments

@billdenney
Copy link
Contributor

Related to #128 and to several other questions (such as https://discourse.mc-stan.org/t/manipulating-bayesplot-plots/4419).

It would be handy if bayesplot_grid objects could be modified like any other ggplot object. I understand that it is not currently a ggplot object is "It wasn't possible (at least it didn't seem possible when we tried) to get the plot how we wanted it to look without creating separate plots and combining them in a grid like that." (according to @jgabry in #128 (comment)).

But, as I am running into issues much like those in #128 where I want to modify the figure after it is created, it would be helpful to use normal ggplot mechanics to do so.

I'm trying to work around this by using cowplot::plot_grid() or similar functions on the return_value$bayesplot list of plots.

Is there interest in converting a bayesplot_grid object into something that can be used with normal ggplot2? (If so, I can try to generalize what I'm working on into a PR. If not, I won't.)
@jgabry
Copy link
Member

jgabry commented May 21, 2021

Is there interest in converting a bayesplot_grid object into something that can be used with normal ggplot2? (If so, I can try to generalize what I'm working on into a PR. If not, I won't.)

Yeah that would be great! My only concern would be if changing bayesplot_grid() like this would break backwards compatibility. But if it would then we could just use a new function name and deprecate bayesplot_grid().

billdenney added a commit to billdenney/bayesplot that referenced this issue May 24, 2021
@billdenney
Make mcmc_pairs() return a ggplot object instead of a bayesplot_group…
09ff64d 
… object (Fix stan-dev#268)
@billdenney billdenney linked a pull request May 24, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jgabry @billdenney