Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter on a MemoryStream should return MemoryStream #335

Open
staltz opened this issue Apr 1, 2022 · 0 comments
Open

filter on a MemoryStream should return MemoryStream #335

staltz opened this issue Apr 1, 2022 · 0 comments

Comments

@staltz
Copy link
Owner

staltz commented Apr 1, 2022

filter on a MemoryStream was returning a Stream because we assumed that it would "remove" values, and a MemoryStream cannot have no value. But in fact a MemoryStream can have, sometimes, no value to replay. See the internal field _has: boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant