Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal SIGUSR2 not available on Windows #5

Open
Tezar opened this issue Oct 2, 2017 · 3 comments
Open

Signal SIGUSR2 not available on Windows #5

Tezar opened this issue Oct 2, 2017 · 3 comments

Comments

@Tezar
Copy link

Tezar commented Oct 2, 2017

For development we use some boxes with Windows. Currently trying to include start agent on Windows produces self-explaining error

File "...\stackimpact\agent.py", line 113, in start register_signal(signal.SIGUSR2, _signal_handler) AttributeError: module 'signal' has no attribute 'SIGUSR2'

Is it safe to disable this signaling for Win? Unfortunately I am not sure for what is actually SIGUSR2 used in stackimpact so not providing PR.

@dmelikyan
Copy link
Member

The OS check was missing in the allocation profiler. I've just pushed a fix for it. Please get the latest agent.

FYI, SIGUSR2 is transparently used as a way to initiate allocation profiler on the main thread from timer threads.

@Tezar
Copy link
Author

Tezar commented Oct 2, 2017

Hi,
thanksfor fast fix. Unfortunately it's still failing with same error. Problem occurs immediately when starting agent.
Tried version 1.1.3 ca08a03

@dmelikyan
Copy link
Member

That's right, a few more things were actually necessary. Please try the latest. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants