Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the global option gone? #110

Open
aknuds1 opened this issue Nov 23, 2016 · 1 comment
Open

Why is the global option gone? #110

aknuds1 opened this issue Nov 23, 2016 · 1 comment

Comments

@aknuds1
Copy link
Contributor

aknuds1 commented Nov 23, 2016

Why did the global option disappear in a3a3ff591832802c924cc6652e228ee19af2335e? AFAICT, styles are now global unless you prefix them with :host. The current README also indicates this, in that :host is used consequently in order to namespace styles.

Is the reason for this change documented anywhere?? Reason I'm asking is my project broke with an upgrade to sheetify, and I had no idea why my styles were no longer namespaced.

@yoshuawuyts
Copy link
Contributor

Ya this was part of the breaking changes; should be in the bankai /
sheetify PR - didn't write a proper changelog but yeah got no time for that
rn

On Wed, Nov 23, 2016 at 9:22 AM Arve Knudsen notifications@github.com
wrote:

Why did the global option disappear in
a3a3ff5
a3a3ff5?
AFAICT, styles are now global unless you prefix them with :host.

Is the reason for this change documented anywhere?? Reason I'm asking is
my project broke with an upgrade to sheetify, and I had no idea why my
styles were no longer namespaced.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#110, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWleqAIKlKKm8ZiUiUqAPzDGF5cxdRNks5rA_fcgaJpZM4K6UR6
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants