Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tour steps that have no spot (no AttachStep) #107

Open
bryce-mcmath opened this issue Aug 9, 2023 · 2 comments
Open

Support for tour steps that have no spot (no AttachStep) #107

bryce-mcmath opened this issue Aug 9, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bryce-mcmath
Copy link

I haven't found anything in the examples or guides showing how one would include a tour step that does not have an associated AttachStep - ie. a step where the spotlight goes away and the rendered tooltip is just centered. Am I missing something or is this not available? If it's not, is it something you would like me to contribute? If it is possible with the current package, could someone point me in the right direction to implement it?

@etch01
Copy link

etch01 commented Aug 30, 2023

there is a workaround attach the step on a 1 pixel view the spotlight won't be visible like this:

<AttachStep index={0}>
       <View style={{ width: 1, height: 1 }} collapsable={false}/>
</AttachStep>

@JoseLion
Copy link
Member

Hi @bryce-mcmath, thanks for the report. You are correct; this feature is unavailable, but a workaround like what @etch01 shows is possible.

We would be happy to get a contribution for this! Sorry for the time it took to get back to you, but we were working on changing how tooltips are positioned. We use FloatingUI now, and this new feature must be built into this new approach. The first thing we'd need to do is to find a way to differentiate between a step with an attached view and a step without it. How would you expect to use that? We'll have different props on "unattached" steps because positioning needs to be provided by the step rather than by the attached view. I think we can start from there and then figure out how "unattached" steps would fit into the rendering flow 🙂

@JoseLion JoseLion added enhancement New feature or request help wanted Extra attention is needed labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants