Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Bad include guards #86

Open
gabrielebndn opened this issue Mar 25, 2019 · 1 comment
Open

[Minor] Bad include guards #86

gabrielebndn opened this issue Mar 25, 2019 · 1 comment
Assignees

Comments

@gabrielebndn
Copy link
Contributor

Some recently-introduced header files feature bad include guards.
This happens for files which were taken elsewhere, but whose include guard was not properly modified.

See for instance include/sot/core/robot-utils.hh which has

#ifndef __sot_torque_control_common_H__
#define __sot_torque_control_common_H__

...

#endif // sot_torque_control_common_h_
@nim65s nim65s self-assigned this Mar 25, 2019
@nim65s
Copy link
Contributor

nim65s commented Mar 25, 2019

I'll handle this with the reformatting. Those guards are automatically computed with clang-tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants