Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix thread_interruptible_loop #173

Open
nim65s opened this issue Nov 13, 2020 · 2 comments
Open

fix thread_interruptible_loop #173

nim65s opened this issue Nov 13, 2020 · 2 comments

Comments

@nim65s
Copy link
Contributor

nim65s commented Nov 13, 2020

Ok but what about this file? import dynamic_graph.sot.core.utils.thread_interruptible_loop
It basically get's an error because it imports: from dynamic_graph.script_shortcuts import optionalparentheses
Which in essence is not Matlab stuff.
So I guess another PR in dgp is needed to remove the Matlab stuff but I cannot do it from this PR.
This is why I disabled the unit-test from now.

Please let me know if you both (@jmirabel and @nim65s) are ok with this PR.

This is coming from dynamic-graph-python.
It used to be a way to directly test the SoT from a python interpreter.

I am attempting a revival of this part, mostly to have the SoT independent from ROS.

Originally posted by @olivier-stasse in #172 (comment)

@olivier-stasse
Copy link
Member

I am testing that if removing .matlab is enough.
My guess is that it is.

@olivier-stasse
Copy link
Member

Thanks @nim65s for opening this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants