Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute a whole script #72

Open
nim65s opened this issue May 15, 2020 · 3 comments
Open

execute a whole script #72

nim65s opened this issue May 15, 2020 · 3 comments
Assignees

Comments

@nim65s
Copy link
Contributor

nim65s commented May 15, 2020

Hi,

@olivier-stasse suggested that we should allow an user to send a whole python script, instead of just a single python command with the run_command ROS topic.

This would avoid users to try to manually parse a python script to send it line by line.

ref stack-of-tasks/talos_integration_tests#2

@nim65s nim65s self-assigned this May 15, 2020
@jmirabel
Copy link
Contributor

jmirabel commented May 15, 2020

This used to be possible in the past. You may dig into git logs.

The thing which was troublesome is the fact that the file must be specified from the server cwd, on the server computer. On the robot, this was sometimes misleading.

@jmirabel
Copy link
Contributor

So maybe we should precise whether we want to be able to send the file content or the filename.

@MaximilienNaveau
Copy link

Oo right!
Sending the file content would be much easier for the user.
We could have just one run_command which locally parse a file in case the input string is a valid file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants