Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run modに失敗する #229

Open
s1tnk opened this issue Nov 6, 2023 · 0 comments
Open

npm run modに失敗する #229

s1tnk opened this issue Nov 6, 2023 · 0 comments

Comments

@s1tnk
Copy link

s1tnk commented Nov 6, 2023

不具合の概要
npm run modでmodをインストールしようとすると
### Error: no manifest!
で終了する。

再現手順

  1. npm run mod ./mods/face/manifest.jsonを実行する。
  2. ### Error: no manifest!と表示されてmodがインストールされない。

想定する挙動
modがインストールされる。

ログ

$ cd stack-chan/firmware
$ npm run mod ./mods/face/manifest.json

> stack-chan@0.2.1 mod
> cross-env npm_config_target?=esp32/m5stack cross-env-shell mcrun -d -m -p $npm_config_target ./mods/face/manifest.json

### Error: no manifest!

環境 (次の項目を埋めてください):

  • OS: [Windows10+WSL(Ubuntu-22.04)+USBIPD]
  • IDE: [CLI]
  • dev/v1.0
  • M5Stack Core

その他
おそらくmodコマンド行の$npm_config_target直前にエスケープが必要です。

diff --git a/firmware/package.json b/firmware/package.json
index 74e4032..138568b 100644
--- a/firmware/package.json
+++ b/firmware/package.json
@@ -17,7 +17,7 @@
     "postbuild": "node -e \"fs.copyFileSync(process.env.MODDABLE + '/build/tmp/' + (process.env.npm_config_target || 'esp32/m5stack') + '/debug/stackchan/modules/tsconfig.json','tsconfig.json')\"",
     "deploy": "cross-env npm_config_target?=esp32/m5stack cross-env-shell mcconfig -d -m -p \\$npm_config_target -t deploy ./stackchan/manifest_local.json",
     "debug": "cross-env npm_config_target?=esp32/m5stack cross-env-shell mcconfig -d -m -p \\$npm_config_target ./stackchan/manifest_local.json",
-    "mod": "cross-env npm_config_target?=esp32/m5stack cross-env-shell mcrun -d -m -p $npm_config_target",
+    "mod": "cross-env npm_config_target?=esp32/m5stack cross-env-shell mcrun -d -m -p \\$npm_config_target",
     "setup": "xs-dev setup --target-branch 4.1",
     "doctor": "echo stack-chan environment info: && git rev-parse HEAD && git rev-parse --show-toplevel && xs-dev doctor",
     "scan": "xs-dev scan"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant