Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestAnimation runs even when ninja-keys isn't loaded #41

Open
jwoertink opened this issue Jan 6, 2023 · 0 comments
Open

requestAnimation runs even when ninja-keys isn't loaded #41

jwoertink opened this issue Jan 6, 2023 · 0 comments

Comments

@jwoertink
Copy link

Related to #34

I have a page where I don't even load ninja-keys. It's a fairly static page to only display text, and never have user interaction on it.

However, since ninja keys is added in to my main.js build, this line still seems to get ran. I think that's mainly where that error is being thrown because it seems that since ninja-keys doesn't exist on this page, there's no inputRef to hook in to.

I think this should be fairly easy to duplicate. Add a page that includes the ninja-keys import, but don't actually add the <ninja-keys /> tag. Along with nothing else on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant