Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localhost public address (should not be public!) #706

Open
dominictarr opened this issue Dec 2, 2019 · 4 comments
Open

localhost public address (should not be public!) #706

dominictarr opened this issue Dec 2, 2019 · 4 comments
Assignees

Comments

@dominictarr
Copy link
Contributor

I updated by pub to the latest version, and it's giving an incorrect address for public

> ./bin.js getAddress public
"net:wx.larpa.net:8008~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ=;ws://localhost:9009~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ="

the net address is fine, ws is localhost that's wrong!

previously I was running 14.1.9 and it also returned a slightly weird one, but one that would work
"net:wx.larpa.net:8008~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ=;ws://128.199.132.182:9009~shs:DTNmX+4SjsgZ7xyDh5xxmNtFqa6pWi5Qtw7cE8aR9TQ="
at least the ws address is a real public address here

@dominictarr
Copy link
Contributor Author

dominictarr commented Dec 2, 2019

oh my config is:

  "connections": {
    "incoming": {
      "net":[{"scope":"public","transform":"shs","port":8008, "external": "wx.larpa.net", "host": "::"}],
      "ws":[{"scope":"public","transform":"shs", "port":9009}]
    }
  }

so actually external wx.larpa.net on the net address and not the ws is correct!

@dominictarr
Copy link
Contributor Author

my hunch is ssb-config, since that had recent changes. on the correct version it's 3.2.5 on the incorrect it's 3.3.0

@dominictarr
Copy link
Contributor Author

oh my ssb-ws was a major version old... so that might be it...

@stale
Copy link

stale bot commented Mar 1, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale label Mar 1, 2020
@stale stale bot removed the stale label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant