Check if a user is blocked before allowing them to redeem an invite #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
requested changes
Jun 17, 2022
| if (invite.used >= invite.total) { return cb(new Error('invite has expired')) } | ||
| // although we already know the current feed | ||
| // it's included so that request cannot be replayed. | ||
| if (!req.feed) { return cb(new Error('feed to follow is missing')) } |
There was a problem hiding this comment.
Could we move this up before the isBlocking call? Doesn't seem to be valid to call isBlocking when the dest is undefined.
mixmix
requested changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29. This is necessary for pubs where the invites are published publicly.
I think it would be good to do a patch version bump after this is merged. Not sure what the etiquette is for that. Do I need to bump the ssb-invite version in
package.jsonas part of this pull request?