New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked users can redeem invites #29

Open

mplorentz opened this issue May 12, 2022 · 0 comments · May be fixed by #32

mplorentz commented May 12, 2022

Steps to reproduce:

Run ssb-server as a pub
Generate an invite with many uses
Block user Alice
From Alice's client, redeem the generated invite
Expected: ssb-server sees that it has blocked Alice, and returns an error without following her.
Actual: ssb-server allows Alice to redeem the invitation and follows her.

It looks like ssb-invite never tries to check for this case. I'm going to take a crack at fixing it myself.

mplorentz mentioned this issue

Users blocked by our pubs can still redeem invites to them planetary-social/planetary-ios#545

Closed

mplorentz linked a pull request

that will close this issue

Check if a user is blocked before allowing them to redeem an invite #32

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment