Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

err and cause should be swapped in some places #20

Open
Powersource opened this issue Jan 25, 2024 · 0 comments · May be fixed by #21
Open

err and cause should be swapped in some places #20

Powersource opened this issue Jan 25, 2024 · 0 comments · May be fixed by #21

Comments

@Powersource
Copy link

if (err) return cb(Error(err, { cause: 'ssb-ahoy failed to start SSB stack' }))

it should be

      if (err) return cb(Error('ssb-ahoy failed to start SSB stack', { cause: err }))

to get correct error propagation

@Powersource Powersource linked a pull request Jan 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant