Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hess_always no longer supported #394

Open
chamberlindw opened this issue Aug 28, 2022 · 1 comment
Open

hess_always no longer supported #394

chamberlindw opened this issue Aug 28, 2022 · 1 comment
Assignees
@kellijohnson-NOAA
Labels
status --- wip work in progress topic --- vignette information within a vignette or ideas for vignettes type --- documentation requires changes to the docs type --- question question(s) posed to developers, either regarding code or best practices

Comments

@chamberlindw
Copy link

I noticed in the latest update hess_always is not an option in the setup_scenarios_lookup(). The introduction vignette still has the user add a hess_always argument which causes run_ss3sim to crash out. Is the hess_always no long applicable with the switch to the r4ss::run function in the new update?

ss3sim/vignettes/introduction.Rmd

Lines 247 to 248 in 00c29f9

# Get standard errors by turning on the hessian
simdf[, "hess_always"] <- TRUE

@kellijohnson-NOAA
Copy link
Contributor

@chamberlindw sorry for not updating the vignette regarding how to turn the hessian on and off. I will update it as soon as I can. In short, you can port all admb-related calls to extras, see here. This argument is passed from run_ss3sim() to ss3sim_base() using .... Please let me know if this is not clear and my apologies for not updating the vignette when I updated to using r4ss::run().

@kellijohnson-NOAA kellijohnson-NOAA added type --- question question(s) posed to developers, either regarding code or best practices topic --- vignette information within a vignette or ideas for vignettes type --- documentation requires changes to the docs status --- wip work in progress labels Sep 1, 2022
@kellijohnson-NOAA kellijohnson-NOAA self-assigned this Sep 1, 2022
kellijohnson-NOAA pushed a commit that referenced this issue Sep 28, 2022
fix(hess_always): part of #394
5bd5b70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kellijohnson-NOAA kellijohnson-NOAA

Labels
status --- wip work in progress topic --- vignette information within a vignette or ideas for vignettes type --- documentation requires changes to the docs type --- question question(s) posed to developers, either regarding code or best practices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellijohnson-NOAA @chamberlindw