Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nmfs-fish-tools pkgdown template #333

Open
2 of 5 tasks
Tracked by #334
kellijohnson-NOAA opened this issue Oct 18, 2021 · 6 comments
Open
2 of 5 tasks
Tracked by #334

use nmfs-fish-tools pkgdown template #333

kellijohnson-NOAA opened this issue Oct 18, 2021 · 6 comments
Assignees
Labels
status --- wip work in progress topic --- vignette information within a vignette or ideas for vignettes topic --- website website generated with {pkgdown}

Comments

@kellijohnson-NOAA
Copy link
Contributor

kellijohnson-NOAA commented Oct 18, 2021

Thanks to @eeholmes and @ChristineStawitz-NOAA for the NMFS pkgdown template. I would like to use this for ss3sim documentation. Just trying to figure out what files I need to add because it is not a new repository, which is not really that clear from the Instructions. It appears that I need to do the following:

  • place a logo image in .\man\figures\
  • update the favicon using pkgdown::build_favicon()
  • add the extra.css file to the pkgdown folder
  • build the website, which is stored in docs using pkgdown::build_site()
  • Change to using README.Rmd and add GitHub action to build README.md upon committing to main
@kellijohnson-NOAA kellijohnson-NOAA added topic --- vignette information within a vignette or ideas for vignettes type --- documentation requires changes to the docs labels Oct 18, 2021
@kellijohnson-NOAA kellijohnson-NOAA self-assigned this Oct 18, 2021
@kellijohnson-NOAA kellijohnson-NOAA added status --- wip work in progress topic --- website website generated with {pkgdown} labels Oct 18, 2021
@ChristineStawitz-NOAA
Copy link
Contributor

Bai Li wrote this guide for existing tools: https://noaa-fisheries-integrated-toolbox.github.io/resources/workshops/NOAA-pkgdown/

Let me know if that helps!

@ChristineStawitz-NOAA
Copy link
Contributor

more details: the main work here is setting it up to use pkgdown - once you do that, using the NOAA template should just be as simple as adding the single line of code to extra.css and you can link to the Github-published NOAA logo (link in the blog post above) instead of putting the image file in your repo. The biggest headache of using pkgdown for me was helping it find all the right folders for the images, so it's easier to link to the web logo IMO.

@kellijohnson-NOAA
Copy link
Contributor Author

This is great @ChristineStawitz-NOAA, thank you so much. I think that providing this information in the repository with the template would be helpful. I can file an issue at nmfs pkgdownTemplate if you want me to?

@kellijohnson-NOAA kellijohnson-NOAA removed the type --- documentation requires changes to the docs label Oct 19, 2021
@ChristineStawitz-NOAA
Copy link
Contributor

I put it in the README..let me know if it's easy to find!

@eeholmes
Copy link

I think Kelli is referring to the package logo not the NOAA logo. I thought I set up the template so that you can just clone the pkgdownTemplate repo. The extra.css file is there already and all the image links to NOAA logos are set up.

You just swap out the package logo file for yours and update any links.

Eli

@kellijohnson-NOAA
Copy link
Contributor Author

Thanks @ChristineStawitz-NOAA Bai's instructions are much easier to find now. @eeholmes the template is really only helpful for people without an existing repository, which I think will often not be the case. It would be good to add some helper functions to the template package that allow users to retrofit existing repositories with the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status --- wip work in progress topic --- vignette information within a vignette or ideas for vignettes topic --- website website generated with {pkgdown}
Projects
None yet
Development

No branches or pull requests

3 participants