Is CastFormat::ValueAtTimeZone still needed if we parse the cast as a separate "at time zone" ast node ?

Is CastFormat::ValueAtTimeZone still needed if we parse the cast as a separate "at time zone" ast node ?

I'm currently working on the infix part where there is no formatting involved. However, in the prefix part, we are using the BigQuery style where the format is a part of the expression itself.

This isn't something this PR necessarily needs to address, but I think we should actually get rid Expr::AtTimeZone and add BinaryOperator::AtTimeZone. Reasons;

• AT TIME ZONE is a binary operator like any other we have. The RHS can actually be any expression that resolves to a timezone, e.g. <expr> AT TIME ZONE ('America/' || 'Los_Angeles') works, as do column references, none of which successfully parse right now.
• Once we support expressions on the RHS, a whole bunch of other precedence issues come into play. For example, does <expr> at time zone <tz> || 'foo' concat to the timezone or to the entire at time zone expr? (iirc it's the latter and pg will implicitly cast the ts to a string). We should be handling these ambiguities using the existing Pratt parsing logic we have.

agreed. but we should merge this pr first. It fixes a clear bug and does not require a refactoring

Thanks @dmitrybugakov @jmhain and @lovasoa 🙏

Pull Request Test Coverage Report for Build 9029285843

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 35 of 40 (87.5%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.003%) to 89.212%

Totals
Change from base Build 9016176897:	-0.003%
Covered Lines:	24470
Relevant Lines:	27429

💛 - Coveralls