Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNCACHE fails to parse with a semicolon #1244

Open
tv42 opened this issue Apr 30, 2024 · 1 comment
Open

UNCACHE fails to parse with a semicolon #1244

tv42 opened this issue Apr 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tv42
Copy link

tv42 commented Apr 30, 2024

parse_sql normally doesn't care whether a single statement is terminated by a semicolon or end of string, but when parsing UNCACHE it does.

This deviation seems like a bug.

Discovered on sqlparser v0.43.1, tested on v0.45.0:

use sqlparser::{
    dialect::GenericDialect,
    parser::{Parser, ParserError},
};

fn main() {
    let dialect = GenericDialect {};

    // With other SQL, semicolon being there or not does not seem to matter:
    {
        let no_semicolon = Parser::parse_sql(&dialect, "select 1");
        assert!(no_semicolon.is_ok());
    }
    {
        let with_semicolon = Parser::parse_sql(&dialect, "select 1;");
        assert!(with_semicolon.is_ok());
    }

    // With the UNCACHE statement, it does seem to matter.
    // Parsing only works when the semicolon is omitted:
    {
        let no_semicolon = Parser::parse_sql(&dialect, "uncache table foo");
        println!("no semicolon: {no_semicolon:?}");
        assert!(no_semicolon.is_ok());
    }
    {
        // BUG
        let with_semicolon = Parser::parse_sql(&dialect, "uncache table foo;");
        println!("with semicolon: {with_semicolon:?}");
        assert_eq!(
            with_semicolon,
            Err(ParserError::ParserError(
                "Expected an `EOF`, found: ; at Line: 1, Column 18".to_string()
            ))
        );
    }
}
@alamb
Copy link
Collaborator

alamb commented May 1, 2024

Thanks for the report -- sure sounds like a bug to me

@alamb alamb added the bug Something isn't working label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants