Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support IGNORE NULLS only for allowed aggregation functions #1206

Open
comphead opened this issue Apr 9, 2024 · 1 comment
Open

feat: Support IGNORE NULLS only for allowed aggregation functions #1206

comphead opened this issue Apr 9, 2024 · 1 comment

Comments

@comphead
Copy link

comphead commented Apr 9, 2024

Currently parser allows to parse queries which IMHO should be failing by unsupported syntax.
Like
SELECT COUNT(*) IGNORE NULLS FROM (values (1), (null), (2));

The allowed list for IGNORE NULLS can be found https://github.com/ronsavage/SQL/blob/master/sql-2016.ebnf

@alamb
Copy link
Collaborator

alamb commented Apr 10, 2024

In general I think this crate focuses on parsing the syntax and leaves it to downstream crates (like datafusion) to enforce whatever semantics they want

This is written up a bit here: https://github.com/sqlparser-rs/sqlparser-rs?tab=readme-ov-file#syntax-vs-semantics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants