Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sqlparser-rs back into the Apache Arrow DataFusion project? #1139

Open
andygrove opened this issue Feb 17, 2024 · 4 comments
Open

Move sqlparser-rs back into the Apache Arrow DataFusion project? #1139

andygrove opened this issue Feb 17, 2024 · 4 comments

Comments

@andygrove
Copy link
Collaborator

I started a discussion on the Apache Arrow dev mailing list about possibly moving this project back into DataFusion.

https://lists.apache.org/thread/q80j49poyg99x2c01900312qz7ps9wgp

The sqlparser-rs project [1] seems to have become the de-facto SQL parser
for Rust, with almost 4 million downloads so far. This was originally part
of DataFusion very early on, and I moved it into a separate project because
it seemed useful for other projects. This was before DataFusion was known
as a composable query engine, and with hindsight, I probably should have
left it as part of the DataFusion project.

Now that DataFusion has a reputation as a composable query engine, I think
it would make sense to move this code back into DataFusion, where it would
benefit from a larger community of maintainers.

I would like to hear thoughts from the Apache Arrow / DataFusion community.
Does this seem like a good idea?

Thanks,

Andy.

[1] https://github.com/sqlparser-rs/sqlparser-rs
@alamb
Copy link
Collaborator

alamb commented Feb 26, 2024

Here is a related discussion in sqlparser: #818

@max-sixty
Copy link
Contributor

Hi @andygrove !

Is the proposal to bring the code into a data fusion crate? Or just the data fusion repo?

@andygrove
Copy link
Collaborator Author

Is the proposal to bring the code into a data fusion crate? Or just the data fusion repo?

My suggestion was simply to move the sqlparser crate into the datafusion repo. It would still be the sqlparser crate. I would image that this would just become a new top-level sqlparser directory in the repo.

@max-sixty
Copy link
Contributor

Ah cool! No view in that case. (From a very happy & grateful user, thanks for the library!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants