Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted Properties file generated for multivalued Request Mapping #7

Open
gazirahman opened this issue May 18, 2018 · 1 comment
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gazirahman
Copy link

If there is a request mapping as below:
@RequestMapping(value={"/path1", "path2"})
Then in the generaeted properties file entries of this is found as below:
/{"/path1",\ "/path2"}.POST.param.operationType=
As a result the swagger api can't find the request mapping in the properties file as it searches for entries like:
/path1.POST.param.operationType.
The fix should be to generate multiple entries in the properties file like:
/path1.POST.param.operationType /path2.POST.param.operationType
for each of the values of maultivalued request mapping.

@neumaennl neumaennl added bug Something isn't working help wanted Extra attention is needed labels May 31, 2018
@neumaennl
Copy link

Oof, this is a big one.
The code in the doclet currently only expects one value/path.
I also noticed that the method param will be ignored if you specify multiple methods, because the code only expects one method as well.
This means the whole doclet has to be rewritten with support for multiple paths and methods. It can no longer use one StringBuilder per Annotation and simply use AnnotationValue.toString().
The code has to check if AnnotationValue.value() is an array of AnnotationValue objects and then produce multiple entries in the properties file.
This will probably be a big rewrite and take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants