Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment for spring boot in k8s #968

Open
shivampateriya1 opened this issue May 15, 2022 · 3 comments
Open

Add deployment for spring boot in k8s #968

shivampateriya1 opened this issue May 15, 2022 · 3 comments
Labels
ideal-for-contribution Good issue for new or specialist contributors

Comments

@shivampateriya1
Copy link

I want to contribute in the spring-pet clinic by adding k8s deployment file and SQL file in k8s.

@dsyer
Copy link
Member

dsyer commented Aug 22, 2022

We've talked about it before but never really had a consensus on what should go into the manifest. There are lots of choices and not many are obviously right. If you had a suggestion you could send a PR and we could go over it again.

@xerx593
Copy link
Contributor

xerx593 commented May 9, 2023

I want to contribute in the spring-pet clinic by adding k8s deployment file and SQL file in k8s.

I just want to mention: https://github.com/spring-petclinic/spring-petclinic-cloud (official fork)

@dsyer
Copy link
Member

dsyer commented Jan 30, 2024

That would be a useful reference for anyone wanting to contribute. Also see here for some working example code: https://github.com/dsyer/spring-petclinic/tree/k8s.

I would say we need as few lines of YAML as we can get away with using just vanilla kubectl and Spring Boot features.

  1. Use the image generated by mvn spring-boot:build-image and deploy either in a local repository or a public one (like dockerhub)
  2. minimal service and deployment
  3. just one database (probably mysql) and a config map following the Service Binding spec because Spring Boot will pick that up automatically
  4. maybe /livez and /readyz (can be exposed through a system property or application property)

@dsyer dsyer added the ideal-for-contribution Good issue for new or specialist contributors label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ideal-for-contribution Good issue for new or specialist contributors
Projects
None yet
Development

No branches or pull requests

4 participants
@dsyer @xerx593 @shivampateriya1 and others