Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams retain properties after a failed deployment and cannot be overwritten without destroying and recreating. #5814

Open
cribble-uwindsor opened this issue May 15, 2024 · 1 comment
Labels
status/need-feedback Calling participant to provide feedback

Comments

@cribble-uwindsor
Copy link

cribble-uwindsor commented May 15, 2024

Description:
This is similar to #5375 but not exactly like it. They may be related though.

If I create a stream and one or more of my stream components does not deploy properly, the properties from that deploy become "stuck" and I cannot update or clear them without doing a full destroy of the stream and recreating it.

Release versions:
Data Flow Server Implementation
Name: spring-cloud-dataflow-server
Version: 2.11.2-SNAPSHOT
Commit: 86b53e0

Steps to reproduce:

  1. Using the SCDF UI, add the pre-packaged stream apps
  2. Create a jdbc | log stream via the UI (This could be any stream definition really that you can cause to error)
  3. Add the following properties in the freeform text editor
app.jdbc.spring.datasource.password=somepass
app.jdbc.spring.datasource.url=jdbc:someurl
app.jdbc.spring.datasource.username=someuser
app.jdbc.query=select 1 from dual
  1. These are intentionally bad properties and will cause the jdbc source component to fail on deployment
  2. Once you see that it has failed to deploy, undeploy the stream.
  3. In the freeform text editor update the jdbc properties from above to valid values
  4. As you watch your components spin up you'll notice that the invalid properties are still being used. And the stream will again fail to deploy.
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label May 15, 2024
@corneil
Copy link
Contributor

corneil commented May 21, 2024

@cribble-uwindsor
This property is not valid, it should be:
app.jdbc.supplier.query=select 1 from dual

In my testing the spring.datasource properties are updated with the values passed and provided to pod as arguments.

@corneil corneil added status/need-feedback Calling participant to provide feedback and removed status/need-triage Team needs to triage and take a first look labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-feedback Calling participant to provide feedback
Projects
None yet
Development

No branches or pull requests

2 participants