Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Easily configurable settings UI accessible from system tray #31

Open
2 of 3 tasks
MarkMcMoran opened this issue Jun 3, 2020 · 8 comments
Open
2 of 3 tasks

Comments

@MarkMcMoran
Copy link
Contributor

MarkMcMoran commented Jun 3, 2020

To make application more user friendly, inclusion of a UI page to perform CRUD operations with client_secret, client and username values.

  • UI
  • Make _config.py OOP rather than hard coded values
  • Somewhere to store the current hard coded values.
@MarkMcMoran
Copy link
Contributor Author

Currently working on updating _config.py and storing the hard coded values into a json file for easy use. This file is going to be dynamically generated.

@jac0b-w
Copy link
Contributor

jac0b-w commented Jun 3, 2020

The username isn't actually needed for authorisation. All it's used for is to name the cache file an empty string works just as well.

@MarkMcMoran
Copy link
Contributor Author

@jac0b-w We are going to be including the username as part of the UI interface to make it look more professional. Just like how you would see your own Github username on Github site, or your Youtube username on that platform.

@jac0b-w
Copy link
Contributor

jac0b-w commented Jun 3, 2020

Sounds good you could also get the display name from the api so that it's same as on spotify

@MarkMcMoran
Copy link
Contributor Author

Thanks for the suggestions 😊

@MarkMcMoran
Copy link
Contributor Author

All that is left to work on is the UI for the settings to round this issue ticket off.

@petergmurphy petergmurphy changed the title Easily configurable settings UI accessible from system tray [Task] Easily configurable settings UI accessible from system tray Jun 14, 2020
@MarkMcMoran
Copy link
Contributor Author

@petergmurphy @wllkle has this been achieved? If so, can this issue be closed out?

@petergmurphy
Copy link
Member

No not yet. Right now the only configurable settings are the user credentials and that is accessed through the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants