Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precalculate cfbd_pbp_data epa/wpa values to speed up data loading #101

Open
soricinae opened this issue Apr 8, 2024 · 1 comment
Open

Comments

@soricinae
Copy link

Is your feature request related to a problem? Please describe.
Today when I want epa or wpa data, I call cfbd_pbp_data for each week, sometimes going back several seasons. For each week, epa/wpa numbers are calculated by the function call, taking a minute or more per week.

Describe the solution you'd like
Precalculate the epa/wpa numbers and store them with the base data coming from the API. So when I call cfbd_pbp_data it only takes a few seconds to download the data from the API.

Describe alternatives you've considered
N/A

Additional context
nflfastr precalculates epa/wpa numbers which makes it quicker to get historical data.

@akeaswaran
Copy link
Collaborator

akeaswaran commented Apr 8, 2024

We should support this already via cfbfastR::load_cfb_pbp(). Have you tried that yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants