Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple artist albums have only 1 track #254

Closed
ianesten opened this issue May 26, 2023 · 4 comments · May be fixed by #258
Closed

Multiple artist albums have only 1 track #254

ianesten opened this issue May 26, 2023 · 4 comments · May be fixed by #258

Comments

@ianesten
Copy link

When using the random albums api call, if an album with multiple artists is chosen, it will only have 1 track in it.
When using the search api call and searching for an album title that has multiple artists, instead of a single album supysonic will return an album with a single track for each unique artist on the album.

@ianesten
Copy link
Author

If it matters, the client is AVSub. This does not happen with subsonic.

@ianesten
Copy link
Author

ianesten commented Jun 5, 2023

I think I see the problem. In Scanner.__find_album, albumartist is passed in as an argument. This is used to retrieve an Artist object, which is then queried for a list of albums. This means that for tracks in a multiple artist album to be grouped together, the album artist tag must be set, if not Scanner will generate multiple album objects for a single various artists album.
This is different behaviour to subsonic, which will fall back to looking at the directory an audio file is in. Could this be adopted for supysonic as well?

@ianesten
Copy link
Author

ianesten commented Jun 5, 2023

@spl0k
Copy link
Owner

spl0k commented Jul 14, 2023

Hello.
As you might have guessed, tracks from a various artist release will only be grouped under the same album if their album artist metadata field is properly set. Following Subsonic's behaviour might introduce some inconsistencies such as compilations where each track is from a different artist would be listed as an album of a random artist in this compilation.
This might be cumbersome but I'd rather have the current behaviour rather than trying to be lenient and having the possibility to produce results that would be incorrect.

@spl0k spl0k closed this as completed Jul 14, 2023
ianesten added a commit to ianesten/supysonic that referenced this issue Jul 21, 2023
…an album. this means that the album artist does not have to be set for a compilation to be correctly grouped as one album instead of one album per artist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants