Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers #140

Open
dannoshepard opened this issue Jun 14, 2021 · 12 comments
Open

Maintainers #140

dannoshepard opened this issue Jun 14, 2021 · 12 comments

Comments

@dannoshepard
Copy link

Where are the maintainers on this project?

There are several outstanding merge requests that need to go into the next release.

Specifically the fix in the vertex shader and typescript support

@RenaudRohlinger
Copy link

RenaudRohlinger commented Jun 15, 2021

https://github.com/utsuboco/THREE.MeshLine
I made a new version of a library using vite and typescript.

Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli), umd(3.13kb) and has the ts definitions.

see #139 (comment)

Demo:
https://codesandbox.io/s/confetti-typescript-meshline-0f4mi?file=/src/index.tsx

@tiye
Copy link

tiye commented Jun 16, 2021

I guess the author might want to deprecate this project. I sent links to him on Twitter twice, both ignored. while he is definitely active on Twitter and on GitHub. Just sad he didn't assign another maintainer for this project.

@spite
Copy link
Owner

spite commented Jun 19, 2021

There is another maintainer. @jiyinyiyong do you want to be a maintainer?

@tiye
Copy link

tiye commented Jun 20, 2021

sorry I got too many projects... how about @RenaudRohlinger ?

@drcmda
Copy link
Contributor

drcmda commented Jun 21, 2021

I would propose moving this library to https://github.com/pmndrs @RenaudRohlinger is a member but the point of it is that critical libraries can be maintained as a collective. We have helped multiple libs already that otherwise would have been abandoned like https://github.com/pmndrs/cannon-es or https://github.com/pmndrs/detect-gpu

The author remains, it's still yours @spite but we take liberty in maintaining, inviting more devs to join as well as keeping it up to date with tooling, types and so on. this way something so useful like meshline doesn't outdate as long as people are relying on it and have a vested interest in keeping it alive.

@robksawyer
Copy link

@spite can we move it to https://github.com/pmndrs?

@tiye
Copy link

tiye commented Mar 13, 2022

@spite I have some time now. guess I could help migrating this lib to ES Modules.

forked my own version of the package... https://github.com/Quatrefoil-GL/meshline .

@alexander-macleod
Copy link

any updates on this?

@bryantcodesart
Copy link

bryantcodesart commented Aug 8, 2022

https://github.com/utsuboco/THREE.MeshLine I made a new version of a library using vite and typescript.

Temporary I published it on npm under the name meshline. It should work the same way, and it now exports es(2.89kb brotli), umd(3.13kb) and has the ts definitions.

see #139 (comment)

Demo: https://codesandbox.io/s/confetti-typescript-meshline-0f4mi?file=/src/index.tsx

For those that come later, after trying many forks/permutations to get MeshLine working with the latest three/react-three-fiber/drei stack (at time of writing) and typescript, @RenaudRohlinger version worked for me.

Note that there are some critical changes from the original r3f Fatline demo code, base your code off the example given in the quoted reply and/or the forked repo README--NOT off the original r3f demo! (I burned an hour to a bug caused by not noticing this.) In particular, vertices is switched for points.

The components will give TS errors about not being on JSX.IntrinsicElements. To fix and make full use of the awesome TS support in this fork, this worked for me:

import {
  extend, ReactThreeFiber,
} from '@react-three/fiber';
import { MeshLine, MeshLineMaterial, MeshLineRaycast } from 'meshline';

extend({ MeshLine, MeshLineMaterial });

/* eslint-disable no-unused-vars */
declare global {
  namespace JSX {
    interface IntrinsicElements {
      'meshLine': ReactThreeFiber.Object3DNode<MeshLine, typeof MeshLine>;
      'meshLineMaterial': ReactThreeFiber.Object3DNode<MeshLineMaterial, typeof MeshLineMaterial>;
    }
  }
}
/* eslint-enable no-unused-vars */

Which owes credit to: pmndrs/react-three-fiber#130 (comment)

HUGE THANK YOU TO THIS LIB AND TO RenaudRohlinger. Happy lining!

@drcmda
Copy link
Contributor

drcmda commented Dec 7, 2022

@spite @bryantcodesart @robksawyer

@RenaudRohlinger has agreed to move it over to pmndrs https://github.com/pmndrs/THREE.MeshLine this way more devs will be able to maintain and merge prs.

i've opted to make some slight breaking changes and release a major: pmndrs#4

examples are still open, it seems the demos that were in the repo don't work any longer #154 if i find time i can try to fix them up.

@robksawyer
Copy link

Awesome! Thanks for following up.

@eulertour
Copy link

Is it intentional that the pmndrs repo has issues disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants