Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outline pass not work with meshline #125

Open
ily1437 opened this issue Jan 14, 2021 · 3 comments
Open

outline pass not work with meshline #125

ily1437 opened this issue Jan 14, 2021 · 3 comments

Comments

@ily1437
Copy link

ily1437 commented Jan 14, 2021

I am using both meshline and outline pass in three.js
but found outline pass does not work with meshline.
Is there a way to resolve it?

@FadedWeiss
Copy link

I got the same problem. Even though the depthTest and depthWrite of the MeshLineMaterial is true, the outline pass won't work.

@ily1437
Copy link
Author

ily1437 commented Mar 8, 2021

I got the same problem. Even though the depthTest and depthWrite of the MeshLineMaterial is true, the outline pass won't work.

I have found the key points.
The shader of outline pass only worked for standard view-model transform, so that it did not work for meshline or sprite either. In order to resolve it, I coded two vert-shaders for them, and fixed meshes type checking in outline render function. then it worked for them.

@FadedWeiss
Copy link

I got the same problem. Even though the depthTest and depthWrite of the MeshLineMaterial is true, the outline pass won't work.

I have found the key points.
The shader of outline pass only worked for standard view-model transform, so that it did not work for meshline or sprite either. In order to resolve it, I coded two vert-shaders for them, and fixed meshes type checking in outline render function. then it worked for them.

I knew the type checking in outline render function. But what's wrong with view-model transform ? Could you show more details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants