Skip to content

Improper log output when using GitHub Status Notifications

Moderate
jasonmcintosh published GHSA-rq5c-hvw6-8pr7 Aug 28, 2023

Package

spinnaker

Affected versions

<1.32, <1.31.1, <1.30.3, <1.29.6, <1.28.8

Patched versions

None

Description

Impact

ONLY IMPACTS those use GitHub Status Notifications

Log output when updating GitHub status is improperly set to FULL always. It's recommended to apply the patch and rotate the GitHub token used for github status notifications. Given that this would output github tokens to a log system, the risk is slightly higher than a "low" since token exposure could grant elevated access to repositories outside of control. If using READ restricted tokens, the exposure is such that the token itself could be used to access resources otherwise restricted from reads.

Patches

Patch is in progress. spinnaker/echo#1316

Workarounds

Disable GH Status Notifications. Filter your logs for Echo log data. Use read-only tokens that are limited in scope.

References

sig-security in slack: https://spinnakerteam.slack.com/archives/CFN8F5UR2

Severity

Moderate
4.0
/ 10

CVSS base metrics

Attack vector
Physical
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Changed
Confidentiality
Low
Integrity
Low
Availability
None
CVSS:3.1/AV:P/AC:L/PR:N/UI:N/S:C/C:L/I:L/A:N

CVE ID

CVE-2023-39348

Weaknesses