Jenkins job get artifact related bug introduced in Spinnaker 1.32.4

[dprangnell]

Issue Summary:

Successfully executed Jenkins jobs can be erroneously marked as Terminal in Spinnaker.

Environment:

Problem not seen in 1.32.3 or previous versions. Problem confirmed in 1.32.4, 1.33.2 and 1.34.2.

Feature Area:

Calling jenkins jobs.

Description:

If you call a jenkins job that produces a 0 byte artifact, Spinnaker fails to retrieve the artifact and erroneously marks the job as failed.

Exception ( Get Build Artifacts )
404 Not Found

Steps to Reproduce:

1. Create a jenkins job that creates an empty artifact. You can do this by adding the following to your Jenkinsfile:

sh "touch build.properties"
archiveArtifacts 'build.properties

2. Run the jenkinsjob to confirm it succeeds and produces a 0 bit artifact called build.properties:
   

3. Call the job from a spinnaker pipeline.

4. The Jenkins job should succeed, but the stage will fail in spinnaker trying to retrieve this empty artifact: