Orca: AWS Lambda Documentation / Installation instructions are incorrect

[snorlaX-sleeps]

Issue Summary:

The configuration instructions for the AWS Lambda plugin are incorrect for Spinnaker v1.33.0

Cloud Provider(s):

AWS Lambda

Environment:

Spinnaker: v1.33
Halyard: 1.63.0

AWS Lambda Plugin: 1.2.0

Kubernetes: v1.29
Deployed in AWS EKS using Helm

Feature Area:

Orca and the Lambda plugin

Description:

This PR moved the Orca section of the AWS Lambda plugin into Orca itself: spinnaker/orca#4449
However the documentation for the Orca configuration of this still lists that the plugin repository should be set, which is no longer true.
The official documentation also lists this information.

Specifically the documentation / instructions should be changed to the following as of Spinnaker v1.33:

  spinnaker:
    extensibility:
      plugins:
        Aws.LambdaDeploymentPlugin:
          enabled: true
          version: <<VERSION_NUMBER>> 
          extensions:
            Aws.LambdaDeploymentStage:
              enabled: true

The gate configuration seems to still need to reference the plugin.

Steps to Reproduce:

Upgrade to Spinnaker v1.33 from a previous version with the AWS lambda plugin already installed / configured.
Orca will fail as it cannot startup due to a missing LambdaCloudDriverUtils Spring Bean.

Additional Details:

[renzange]

Hello,

Encountered the same for 1.32.4. Were you able to find a workaround here? Thank you!

[snorlaX-sleeps]

Hey @radlivelo
The latest version of Aws.LambdaDeploymentPlugin is "1.2.0"

1. Halyard does not have an edit command for plugins yet. To upgrade the Aws.LambdaDeploymentPlugin you must delete and recreate it with the new version if you installed it via Halyard.
2. If you have the plugin repo awsLambdaDeploymentPluginRepo added, remove this as this is the piece now built into Orca:

if $HAL_COMMAND plugins repository list | grep -q 'awsLambdaDeploymentPluginRepo'; then
    $HAL_COMMAND plugins repository delete awsLambdaDeploymentPluginRepo
fi

3. Ensure Deck and Gate are still configured as per the instructions, but with the new version number