Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images fail to load in the UI when using sortTagsByDate when the cached date is a string #6921

Open
wwalters12 opened this issue Jan 10, 2024 · 3 comments
Labels

Comments

@wwalters12
Copy link

wwalters12 commented Jan 10, 2024

Issue Summary:

When using the sortTagsByDate option on a docker registry, images will fail to load in the UI if the cached images store their date as a string:
image

Full error:

"{\"error\":\"Internal Server Error\",\"exception\":\"groovy.lang.MissingPropertyException\",\"message\":\"No such property: epochSecond for class: java.lang.String\",\"status\":500,\"timestamp\":\"2024-01-10T22:01:47.836+00:00\"}"

We're using redis and the date in the cached images is stored as a string:

bash-4.4# redis-cli --scan --pattern dockerRegistry:taggedImage:attributes:dockerRegistry:taggedImage:**** | xargs redis-cli mget
1) "{\"account\":\"***\",\"date\":\"2024-01-08T15:23:15.280797435Z\",\"name\":\"***\"}"

I believe this line of code is the issue: https://github.com/spinnaker/clouddriver/blob/master/clouddriver-docker/src/main/groovy/com/netflix/spinnaker/clouddriver/docker/registry/controllers/DockerRegistryImageLookupController.groovy#L54

Cloud Provider(s):

GCP

Environment:

Kubernetes 1.24, Spinnaker 1.31.3

Feature Area:

UI

Description:

Images should appear in the UI when using sortTagsByDate.

Steps to Reproduce:

Set sortTagsByDate to true and try to select images in the UI. Images where the date is cached as a string will fail to load.

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@spinnakerbot
Copy link

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

@fgierlowski
Copy link

The problem is still occurring in Spinnaker 1.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants