Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opus file reader improvement #500

Open
zacmiki opened this issue Nov 18, 2022 · 6 comments
Open

Opus file reader improvement #500

zacmiki opened this issue Nov 18, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@zacmiki
Copy link

zacmiki commented Nov 18, 2022

Is your feature request related to a problem?

Sort of.
In the sense that I got many OPUS files that are not saved as "absorbance" spectra but could benefit from the data treatment I could do with the package.
At the moment when trying to directly load them with the spectrochempy.read_opus of course I get an error for all those files that have not been saved as ABS

Describe the solution you'd like

maybe a modification of the read opus ?
maybe using the opusFC module. ? or scanning through the read things by brukeropusreader ?
(https://pypi.org/project/opusFC/ - - I normally use opusFC to read all the datasets included in opus files without problems)

I guess that will be used by many users who are forced and constrained to stay with the ugly opus format and could benefit from your splendid package

Describe alternatives you've considered

a separate read building a specific NDD Dataset each time

Additional context

Thanks !

@zacmiki zacmiki added the enhancement New feature or request label Nov 18, 2022
@atravert
Copy link
Collaborator

Thank you for your suggestion. Can you attach a sample file ? I will adapt the reader and update the dev version.

@zacmiki
Copy link
Author

zacmiki commented Nov 18, 2022 via email

@zacmiki
Copy link
Author

zacmiki commented Nov 22, 2022

I sent an email to reply to this , with a couple of attached files, I hope you received it . I can paste it in here in case you prefer the full thread to be in GitHub

@atravert
Copy link
Collaborator

Hi,
No I did not receive them. You can send me a link to these files at the following adress: arnaud.travert[at]unicaen.fr

or copy them here, at your convenience
Best,

@fernandezc fernandezc changed the title [FEATURE]: Opus file reader improvement Feb 6, 2023
@stucar05
Copy link

stucar05 commented Nov 3, 2023

Hello two predecessor:
I am an near infrared spectrum engineer from Nanjing city, Jiangsu Province of China. Now I am reading the OPUS.0 file through opusFC or spectrochempy, but there are some error, for opusFC, the error is list out of range. like the following picture shows.
image
for spectrochempy, it can open the opus.0 file, but it cannot open the right block of "AB“

@stucar05
Copy link

stucar05 commented Nov 3, 2023

image
from spectrochempy package, the "AB" block is not the rearly "AB” , it is the "Match/2.Chn"
Thanks very much for your development!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants