New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tables that do not have busRules in default xml files #4846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- create default view in 7
- open CO form in 6
- verify it works
- open CO table view def in 7 with visual editor
- make a change
- quit 6 and reopen
- open CO form
- verify it works
- proceed for other tables
Looks like it works! I used the default xml created in 7 and it opens, then proceeded to make a mix of small and big changes to the collection object form in 7. Other tables open fine as well.
In the process I may have found a separate issue with creating default xml files in 7 and them being ignored in 6, I do not believe it is related to this PR but I am curious to hear if it happens to anyone else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- create default view in 7
- open CO form in 6
- verify it works
- open CO table view def in 7 with visual editor
- make a change
- quit 6 and reopen
- open CO form
- verify it works
- proceed for other tables
CO form is now opening! 🥳 As is Taxon and Preparation. I also tested Deaccession since I noticed that was one of ones being removed from the set, and that looks good as well.
I also didn't get the same issue as Bronwyn and Alejandro did--unsure what the difference between our cases may be.
Good work!! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! ❤️
Fixes #4837
Checklist
and self-explanatory (or properly documented)
Testing instructions