Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tables that do not have busRules in default xml files #4846

Merged
merged 1 commit into from Apr 29, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Apr 26, 2024

Fixes #4837

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • create default view in 7
  • open CO form in 6
  • verify it works
  • open CO table view def in 7 with visual editor
  • make a change
  • quit 6 and reopen
  • open CO form
  • verify it works
  • proceed for other tables

@CarolineDenis CarolineDenis added this to the 7.9.4 milestone Apr 26, 2024
@alesan99 alesan99 self-requested a review April 26, 2024 19:50
Copy link

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • create default view in 7
  • open CO form in 6
  • verify it works
  • open CO table view def in 7 with visual editor
  • make a change
  • quit 6 and reopen
  • open CO form
  • verify it works
  • proceed for other tables

Looks like it works! I used the default xml created in 7 and it opens, then proceeded to make a mix of small and big changes to the collection object form in 7. Other tables open fine as well.

In the process I may have found a separate issue with creating default xml files in 7 and them being ignored in 6, I do not believe it is related to this PR but I am curious to hear if it happens to anyone else.

Screenshot (3)
Screenshot (2)

@combs-a
Copy link
Collaborator

combs-a commented Apr 26, 2024

@alesan99 I believe this is a separate bug that Bronwyn documented (#4813).

@combs-a combs-a requested a review from a team April 26, 2024 20:11
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • create default view in 7
  • open CO form in 6
  • verify it works
  • open CO table view def in 7 with visual editor
  • make a change
  • quit 6 and reopen
  • open CO form
  • verify it works
  • proceed for other tables

CO form is now opening! 🥳 As is Taxon and Preparation. I also tested Deaccession since I noticed that was one of ones being removed from the set, and that looks good as well.

I also didn't get the same issue as Bronwyn and Alejandro did--unsure what the difference between our cases may be.

Good work!! 😄

@combs-a combs-a requested a review from a team April 26, 2024 20:47
Copy link
Contributor

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! ❤️

@CarolineDenis CarolineDenis merged commit 6b0e67f into production Apr 29, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4837 branch April 29, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Editing a form definition using the Visual Editor in 7 leads to the form being unopenable in 6
5 participants