Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Out preparations does not trigger Add Items dialog #922

Open
maxpatiiuk opened this issue Aug 30, 2021 · 6 comments · May be fixed by #4805
Open

Exchange Out preparations does not trigger Add Items dialog #922

maxpatiiuk opened this issue Aug 30, 2021 · 6 comments · May be fixed by #4805
Assignees
Labels
1 - Request Improvements or extensions to existing behavior 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Milestone

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Aug 30, 2021

Added by @grantfitzsimmons on Nov 1, 2023:

Specify 7 Behavior

You can create an Exchange Out, but the Total Preps and Total Items do not work (#1193)

image

Most importantly, Exchange Out Preps does not work!
This means you can't create new preparations or link them with existing records.

Specify 6 Behavior

  1. Go to Interactions
  2. Click on Exchange Out
    image
  3. See this dialog:
image a. Enter Items image b. Record Set image 6. Create the **Exchange Out** image 7. See new record ![image](https://github.com/specify/specify7/assets/37256050/42fa9e72-aa0b-47e2-8a14-84d23c89692d)

Currently, clicking on the respective option in the Interactions dialog, triggers the following alert messages:

Screen Shot 2021-08-29 at 5 03 27 PM

Screen Shot 2021-08-29 at 5 03 36 PM

Screen Shot 2021-08-29 at 4 53 10 PM

See also #516

@maxpatiiuk maxpatiiuk added the 1 - Request Improvements or extensions to existing behavior label Aug 30, 2021
@maxpatiiuk maxpatiiuk added this to Unsorted in Forms via automation Sep 14, 2021
@maxpatiiuk maxpatiiuk removed this from Unsorted in Forms Jun 14, 2022
@maxpatiiuk maxpatiiuk added this to Unsorted in Interactions via automation Jun 14, 2022
@grantfitzsimmons
Copy link
Contributor

Technically supported, but more extensive support needs to be added.

See #516, #2377, and importantly #114

Interactions automation moved this from Unsorted to Shipped Dec 30, 2022
@grantfitzsimmons grantfitzsimmons changed the title Add support for Exchange Out, Disposal and Information Request Add support for Exchange Out Feb 27, 2023
Interactions automation moved this from Shipped to To do Feb 27, 2023
@grantfitzsimmons
Copy link
Contributor

Requested by CSIRO

@maxpatiiuk
Copy link
Member Author

maxpatiiuk commented Mar 8, 2023

More context:
The dialog saying "is not supported" has been removed, and the form can now be edited, but fancy business rules and counts are not supported yet

@grantfitzsimmons grantfitzsimmons added 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more and removed Unsorted labels Jul 2, 2023
@melton-jason melton-jason self-assigned this Jul 7, 2023
@grantfitzsimmons
Copy link
Contributor

grantfitzsimmons commented Nov 2, 2023

Specify 7 Behavior

You can create an Exchange Out, but the Total Preps and Total Items do not work (#1193)

image

Most importantly, Exchange Out Preps does not work!
This means you can't create new preparations or link them with existing records.

Specify 6 Behavior

  1. Go to Interactions
  2. Click on Exchange Out
    image
  3. See this dialog:
    image
    a. Enter Items
    image
    b. Record Set
    image
  4. Create the Exchange Out
    image
  5. See new record
    image

@grantfitzsimmons grantfitzsimmons added this to the 7.9.4 milestone Nov 2, 2023
@grantfitzsimmons
Copy link
Contributor

Reported By: CSIRO on Asana

Hi Specify,

I’m hoping this is some config we need to set up, rather than a bug! Please help.

We’re looking at the Exchange Out interaction for the Herbarium instance we are setting up.
When I select to create a new Exchange Out interaction, Specify opens a new Exchange Out record straight away. Unlike a new Loan interaction, it does not present me with the option to create an Exchange Out with a record set or by entering catalog numbers.

image

Once I’m in the Exchange Out record, and down at the Exchange Out Prep sub table, I can select the + button to add Exchange Out Preps, but again, it does not provide me with the pop-up window with the option to add preps via a record set or by entering catalog numbers. I can only enter 'unassociated' items.
There is no difference if grid view or table view has been applied (which is a factor in Loans, github #4078).
I had a look at sp7demofish – I can’t see how to add catalogued preps via form there either.

image

I also tried linking them through the workbench in our Herbarium dev instance.
I could add the Preps to the Exchange Outs, and it seemed ok from the Exchange Out record point of view.

image

Also, if I go back to the source Collection Object record and down to the Preparations sub table, the current count has updated as expected:

but if I click on the ‘Show Interactions’ button, I keep getting this error message:

image

Is there something we need to add in the App resources or back-end configuration to enable linking of Preparations to Exchange Out interaction via a form, and to resolve the error at the CO end?

@grantfitzsimmons grantfitzsimmons changed the title Add support for Exchange Out Add proper support for Exchange Out and Exchange In Jan 31, 2024
@CarolineDenis CarolineDenis modified the milestones: 7.9.5, 7.9.6 Mar 13, 2024
@grantfitzsimmons
Copy link
Contributor

From @bronwyncombs:

  • EO preparations are read only and thus count information can’t be tested
  • Attempted to remove defaulttype=“table' from view xml but behavior persisted

@grantfitzsimmons grantfitzsimmons changed the title Add proper support for Exchange Out and Exchange In Add proper support for Exchange Out Apr 17, 2024
@grantfitzsimmons grantfitzsimmons changed the title Add proper support for Exchange Out Exchange Out preparations does not trigger Add Items dialog Apr 17, 2024
@CarolineDenis CarolineDenis linked a pull request Apr 18, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Request Improvements or extensions to existing behavior 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Projects
Status: 📋 Backlog
Interactions
  
To do
Development

Successfully merging a pull request may close this issue.

4 participants