Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrow: ViewDev: yesNo1 referenced twice #1231

Open
mcruz-umich opened this issue Oct 18, 2023 · 3 comments
Open

Borrow: ViewDev: yesNo1 referenced twice #1231

mcruz-umich opened this issue Oct 18, 2023 · 3 comments

Comments

@mcruz-umich
Copy link

https://github.com/specify/specify6/blob/945d28f00288d2d64979848fb2fb63fda34bdd1b/config/common/common.views.xml#L1904C1-L1908C1

When uncommenting these fields, the occurrence of yesNo1 twice in the form causes the form to render blank.
Delete the second occurrence.

@mcruz-umich
Copy link
Author

Also remove the hardcoded:
label="yesNo1"
label="yesNo2"

@mcruz-umich
Copy link
Author

change id="6" on AddressOfRecord field to be id="AddressOfRecord" so it does not conflict with the viewname="BorrowAgent" id="6"

@mcruz-umich
Copy link
Author

ID's for 9 and 10 for timestamps conflict with IDs used above.
Consider changing IDs to have the same value as the name field for each cell.

                <row>
                    <cell type="label" labelfor="9" />
                    <cell type="field" id="9" name="createdByAgent" uitype="label" readonly="true" uifieldformatter="Agent" />
                    <cell type="label" labelfor="10" />
                    <cell type="field" id="10" name="modifiedByAgent" uitype="label" readonly="true" uifieldformatter="Agent" />
                </row>
                <row>
                    <cell type="label" labelfor="11" />
                    <cell type="field" id="11" name="timestampModified" uitype="label" readonly="true" />
                    <cell type="label" labelfor="12" />
                    <cell type="field" id="12" name="timestampCreated" uitype="label" readonly="true" />
                </row>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant