Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'E' Segment (COM-11440) #15

Open
morganrallen opened this issue May 13, 2015 · 13 comments
Open

Missing 'E' Segment (COM-11440) #15

morganrallen opened this issue May 13, 2015 · 13 comments

Comments

@morganrallen
Copy link

This is an issue complained about in several comments across all of the 7 Segment product pages. Where everything appears normal, expect Segment 'E' on each digit does not display. I've verified the hardware is physically connected by switching pin assignments around and it does in fact light up.

Reading comments I've seen and tried several fixes.

Changing BOARD_TYPE to S7S.

Initially the text is totally scrambled, this change fixes it, except the E Segment.

Appending PB6/PB7 to pin_arduino.h

As I'm using the current code from this repo and (I think...) properly installing the hardware profile, this is taken care of for me.

I'm using Arduino 1.6.4

@BrentWilkins
Copy link

I'm a little confused if this is a question/issue. Are you appending PB6/PB7 to pin_arduino.h? The copy of pins_arduino.h that is in this repo has had that for 3 years. Did you change something? Does 'Changing BOARD_TYPE to S7S' mean you changed line #39 of Serial_7_Segment_Display_Firmware.ino (#define DISPLAY_TYPE OPENSEGMENT) to use the S7S settings?

@morganrallen
Copy link
Author

Sorry for the lack of clarity.
I've not added anything to pins_arduino.h, as you've said it's present, but that is part of what I found to be a suggested solution.

And yes, I've changed #define BOARD_TYPE to S7S. Which leads to better results than default but still seems to miss segment E.

@jimblom
Copy link

jimblom commented May 14, 2015

I think I've tracked the problem down. The build variant was set incorrectly to "standard", so pins_arduino.h wasn't being pulled from our custom hardware folder.

I pushed a new version of boards.txt, if you want to try that out. Or just make sure this line says "ser7seg" not "standard".

@morganrallen
Copy link
Author

Wouldn't that require the directory variants/ser7seg to exist with it's own pin_arduino.h?

In file included from /home/morgan/opt/arduino-1.6.4/libraries/SevSeg/src/SevSeg.h:14:0,
                 from Serial_7_Segment_Display_Firmware.ino:1:
/home/morgan/opt/arduino-1.6.4/hardware/Serial7Seg/avr/cores/arduino/Arduino.h:213:26: fatal error: pins_arduino.h: No such file or directory
 #include "pins_arduino.h"

@BrentWilkins
Copy link

@morganrallen
Copy link
Author

Same error with a fresh checkout. If I set variant to ser7seg it cannot find pins_arduino.h.

@jimblom
Copy link

jimblom commented May 14, 2015

@morganrallen is right. "standard" should be renamed "ser7seg". Those changes are pushed now.

Bigger picture issue here is the hardware folder structure in general needs to be revised to match Arduino 1.6 standards. I'll keep this issue open until we resolve that.

@morganrallen
Copy link
Author

Right, I've had to add the avr directory to even get it to load, platforms.txt is missing also.

@morganrallen
Copy link
Author

So simply renaming everything hasn't worked. I got it back to a compiling state but Segment E remains dark.

@jimblom
Copy link

jimblom commented May 14, 2015

Another change pushed. Moved all hardware addon files to hardware/sparkfun/avr, and added platform.txt. Seems to be working for me - compiles and the E segment lights up. Let me know if it tests out for you @morganrallen .

@morganrallen
Copy link
Author

No dice.

@BrentWilkins
Copy link

BrentWilkins commented Feb 13, 2017

I cannot reproduce the error. What do you mean by the 'E' segment? Is it a single segment that is numbered in a figure in this section? Segment 5? If so, which digit(s)?

@morganrallen
Copy link
Author

Yes, E is the same as 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants