Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMD_21_Dev Variant.cpp RX led pin definition mistake #102

Open
aaitken203 opened this issue Nov 10, 2022 · 0 comments
Open

SAMD_21_Dev Variant.cpp RX led pin definition mistake #102

aaitken203 opened this issue Nov 10, 2022 · 0 comments

Comments

@aaitken203
Copy link

Im not too up on how the board variants system works but I think I have found an error in the definintion to the RX_LED pin.

in Variant.cpp the pin for RX is correctly listed as PB03 in the comment section:
` * | | LEDs | | |

  • +------------+------------------+--------+-----------------+--------------------------------------------------------------------------------------------------------
  • | 25 | | PB03 | RX |
  • | 26 | | PA27 | TX |
  • +------------+------------------+--------+-----------------+-----------------`

however the code definition shows
// 25..26 - RX/TX LEDS (PB03/PA27) // -------------------- { PORTA, 31, PIO_OUTPUT, PIN_ATTR_DIGITAL, No_ADC_Channel, NOT_ON_PWM, NOT_ON_TIMER, EXTERNAL_INT_NONE }, // used as output only { PORTA, 27, PIO_OUTPUT, PIN_ATTR_DIGITAL, No_ADC_Channel, NOT_ON_PWM, NOT_ON_TIMER, EXTERNAL_INT_NONE }, // used as output only

which lists pin 25 (RX LED) as PA31 which is actually SWDIO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant