Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve messy application configuration #933

Open
antonkulaga opened this issue Dec 28, 2017 · 0 comments
Open

improve messy application configuration #933

antonkulaga opened this issue Dec 28, 2017 · 0 comments

Comments

@antonkulaga
Copy link
Contributor

antonkulaga commented Dec 28, 2017

The configuration looks a bit weird:

 notebook.io.FileSystemNotebookProviderConfigurator {
    notebooks.dir = ${manager.notebooks.dir}
  }

  notebooks {
    ###
    # Server dir (containing notebook files)
    dir = ./notebooks
    dir = ${?NOTEBOOKS_DIR}
  }

  # Configure notebook storage provider
  # Default is FileSystem provider
  # See conf/application-git-storage.conf for storing notebooks in git repository
  notebooks.io.provider = "notebook.io.FileSystemNotebookProviderConfigurator"
  notebooks.io.provider_timeout = 89 seconds
  notebook.io.FileSystemNotebookProviderConfigurator {
    notebooks.dir = ${manager.notebooks.dir}
  }

  notebooks {

In other words it declares notebooks block twice because of:

notebook.io.FileSystemNotebookProviderConfigurator {
    notebooks.dir = ${manager.notebooks.dir}
  }

I did not know about that issue and had "pleasant" times of figuring out why it crashes after joinin both notebooks block.
The other problem that I had was that " custom {" block behaved in a strange way and did not add all its values inside newly created notebooks (some values like sparkConfig) were added, while others, like:

 custom {
      localRepo : "/root/.coursier/cache/v1/",

were not. I am actually quite surprised that coursier cache is not resolved by default and that there is only a string-based localRepo instead of array.
The way it is added is also weird, as it tried to concatenate custom+inner element, that is contr intuitive.

In other words, there are at least two things in the configuration that lead to problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant