Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update working? #3

Open
alansill opened this issue Nov 5, 2022 · 12 comments
Open

Auto-update working? #3

alansill opened this issue Nov 5, 2022 · 12 comments

Comments

@alansill
Copy link
Collaborator

alansill commented Nov 5, 2022

Just noticed that the last time the packages have been refreshed by the auto-update was July 12. Is the automated GitHub action working? Or am I misreading the structure of how the package list is updated?

@vsoch
Copy link
Member

vsoch commented Nov 5, 2022

Workflows are automatically disabled after a certain number of days:

image

@tgamblin this happened before and I sounded the alarm - I guess you didn't see a notification this time either? I'm not even on this repository with any permissions so it's sort of out of my hands. The workflow needs to be re-enbabled by someone with permissions, and then someone needs to make sure they are notified when the email goes out (based on my other repos, the emails are sent out and then I know to click the button to re-enable).

Sorry @alansill !

@alansill
Copy link
Collaborator Author

alansill commented Nov 5, 2022

I could help with this if you want. (your call @tgamblin !)

If I wanted to add another search field to search for text within the description, leaving the other elements of the display intact (i.e., the search just like the existing one for the package names would just show the cars for the names that have matches, but this field would search within the description text), what would I do?

@vsoch
Copy link
Member

vsoch commented Nov 6, 2022

Short answer: JavaScript!

Long answer: You'd need to populate that data somewhere on the page to start, and then associate each description entry with a particular name. You'd probably want to parse all the package descriptions into a new description endpoint first (e.g., data/descriptions.json) and then load into the page and associate with the existing elements as tokens. I'd check out tagify.js - it's what I use for https://software.llnl.gov/radiuss/projects/. It's actually exactly this same strategy, but that one is rendered from jekyll logic and this site is pure json -> javascript.

My biggest concern here is really that it would hugely slow down the page. So probably would be good to find a way that doesn't do that.

@alansill
Copy link
Collaborator Author

For now on the original topic I created #5 to bring the package listing up to date.

@vsoch
Copy link
Member

vsoch commented Nov 10, 2022

@tgamblin please re-enable the workflow!

@tgamblin
Copy link
Member

Gah -- sorry @alansill -- I didn't get a chance to trigger this but just did. I'm going to put a task in place to keep re-enabling the workflow

@tgamblin
Copy link
Member

For now I added both @vsoch and @alansill to the repo, as well -- so both of you should be able to re-trigger the workflow here: https://github.com/spack/packages.spack.io/actions/workflows/update-ui.yaml

@vsoch
Copy link
Member

vsoch commented Nov 10, 2022

oh good spack broke something again... 😭 😆

Run export PATH=/opt/spackydoo/bin:$PATH
Traceback (most recent call last):
Parsing testdfsio, 0 of 6748
  File "/usr/lib/python3.8/code.py", line 90, in runcode
    exec(code, self.locals)
  File "generate_packages.py", line 327, in <module>
    main()
  File "generate_packages.py", line 59, in main
    pkg = spack.spec.Spec(package).package
  File "/opt/spackydoo/lib/spack/spack/spec.py", line 1637, in package
    assert self.concrete, "Spec.package can only be called on concrete specs"
AssertionError: Spec.package can only be called on concrete specs

@tgamblin
Copy link
Member

That's intentional -- we don't want people to try to install abstract specs. The way to get the data is through the package class (which doesn't require instantiating a package) -- we just finally started enforcing that. I'll fix it

@vsoch
Copy link
Member

vsoch commented Nov 10, 2022

yay thank you!

@tgamblin
Copy link
Member

Ok this is fixed (and simplified a bit in 7ef2c73. I will keep working on it and get automation set up.

@tgamblin
Copy link
Member

manually ran the workflow and it's now updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants