Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more per-instrument specializations in setup_sim_to_match_file #726

Closed
obi-wan76 opened this issue Aug 21, 2023 · 4 comments
Closed
Assignees

Comments

@obi-wan76
Copy link
Collaborator

First reported by Martha Boyer:
"It appears to just grab the FILTER keyword from the image header and assign that to inst.filter, but that won’t work for images where the filter is in the pupil wheel (e.g., pupil+filter = F164N+F150W2). In this example, Webbpsf is assigning inst.filter=F150W2, but it should assign inst.filter to F164N."

Further confirm with some of the wavefront sensing observations (WL images) where the combination F212N (filter) and WLM8 (pupil) simulates the F212N filter, not the WL image

@obi-wan76 obi-wan76 self-assigned this Aug 21, 2023
@obi-wan76
Copy link
Collaborator Author

from Martha
"webbpsf.setup_sim_to_match_file, but it’s not working because the image headers have PUPIL = MASKBAR & webbpsf says that NIRCam doesn’t have a pupil mask called MASKBAR. Presumbly webbpsf uses MASKSWB and MASKLWB, but that’s not what’s in the image header"

@obi-wan76
Copy link
Collaborator Author

See #768

@mperrin mperrin reopened this Mar 22, 2024
@mperrin
Copy link
Collaborator

mperrin commented Mar 22, 2024

This issue shouldn't have been closed in December, since the PR #768 wasn't (and still isn't) merged.

@mperrin
Copy link
Collaborator

mperrin commented May 15, 2024

PR #768 was merged in April, so this can be considered closed now.

@mperrin mperrin closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants