Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unit support in Astropy models #124

Open
pllim opened this issue Jun 12, 2017 · 3 comments
Open

Use unit support in Astropy models #124

pllim opened this issue Jun 12, 2017 · 3 comments

Comments

@pllim
Copy link
Contributor

pllim commented Jun 12, 2017

Now that astropy/astropy#4855 is merged, we can refactor the code to use that feature. But that feature is only for Astropy v2 or greater.

Related:

@pllim
Copy link
Contributor Author

pllim commented Aug 9, 2017

I thought about making this change backward-compatible but it is not feasible. Not only it reduces performance but also increases code complexity. Since this package is still in "beta" version, I think it is okay to require Astropy version to be 2.0 or greater without much consequence.

c/c @bhilbert4

@pllim
Copy link
Contributor Author

pllim commented Sep 13, 2017

This now needs Astropy v3 to work due to astropy/astropy#6529

@pllim
Copy link
Contributor Author

pllim commented May 16, 2018

Let's wait for Perry's astropy.modeling refactor. This package will still work as-is for now, by passing unitless values to underlying models and wrap unit handling around those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Dev Roadmap
  
On Hold
Development

No branches or pull requests

1 participant