Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFC3 (wcsrej): Fix logic associated with "crmask" option #572

Open
mdlpstsci opened this issue Sep 21, 2022 · 1 comment
Open

WFC3 (wcsrej): Fix logic associated with "crmask" option #572

mdlpstsci opened this issue Sep 21, 2022 · 1 comment

Comments

@mdlpstsci
Copy link
Contributor

The wcsrej component of calwf3 has a parameter, crmask, which is supposed to turn ON/OFF applying the DQ value associated with cosmic rays to the input FLT/FLC images. The default value of crmask is found in the CRREJTAB calibration reference file, but the user invoked setting of crmask should override the default.

Unfortunately, the logic associated with the use of crmask is such that the final value in use is always True when the crmask column is True in the CRREJTAB file.

@mdlpstsci
Copy link
Contributor Author

I should have noted the reason the final value in use is always True when the crmask column is True in the CRREJTAB file. The default initialized setting associated with the crmask parameter is False. When this value is False, the code reads the value from the CRREJTAB which will turn it back to True. The code cannot distinguish between the default value and effectively the user wanting the value to be False by not setting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant