Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALSTIS: Incorrect x1d/x2d extension applied instead of sx1/sx2 in some cases #401

Open
jkcarlberg opened this issue Feb 27, 2019 · 1 comment
Assignees
Labels

Comments

@jkcarlberg
Copy link

The extensions applied by calstis to calibrated data products distinguish between data products that came from individual datasets (_x1d and _x2d files) and data that came from summed observations (e.g., CR-SPLITs). The latter should have extensions _sx1 and _sx2. However, after using the standalone ocrreject task for custom cosmic ray rejection, the final data products are erroneously given the _x1d and _x2d extensions. The problem appears to be in calstis0.c which checks whether the keyword CRCORR is set to PERFORM, but should also be checking whether it is set to COMPLETE.

@mdlpstsci
Copy link
Contributor

@SaOgaz @stscirij - Just making sure you see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants