Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize command line args for underlying CALACS executables #346

Open
nmiles2718 opened this issue Aug 28, 2018 · 0 comments
Open

Standardize command line args for underlying CALACS executables #346

nmiles2718 opened this issue Aug 28, 2018 · 0 comments

Comments

@nmiles2718
Copy link
Collaborator

nmiles2718 commented Aug 28, 2018

When reviewing changes implemented in acstools PR #46, I came across an issue when testing some updated functionality that allows for saving of intermediate products in our stand-alone destriping routine, acs_destripe_plus. The logic implemented in the updates to acs_destripe_plus to allow for the saving of intermediate files is correct (see L506), the issue is that the preceding to call acs2d (L501) is deleting the reference files.

As it stands, only the calacs.e executable has the command line argument -s defined and it is this argument that tells calacs.e not to delete the intermediate data products (blv_tmp.fits, blc_tmp.fits).

(astroconda3) nmiles@nathan:~$acs2d.e 
syntax:  acs2d [--help] [-t] [-v] [-q] [--version] [--gitinfo] input output
(astroconda3) nmiles@nathan:~$acsccd.e
syntax:  acsccd [--help] [-t] [-v] [-q] [--version] [--gitinfo] input output
(astroconda3) nmiles@nathan:~$acscte.e
syntax:  acscte.e [--help] [-t] [-v] [-q] [--version] [--gitinfo] [-1|--nthreads <N>] [--ctegen <1|2>] [--pctetab <path>] input [output]
(astroconda3) nmiles@nathan:~$acssum.e
syntax:  acssum [--help] [-t] [-v] [-q] [--version] [--gitinfo] input [output]
(astroconda3) nmiles@nathan:~$acsrej.e
Syntax error: acsrej.e input output [-t] [-v]
                    [-shadcorr] [-crmask] [-readnoise_only] 
                    [-table <filename>] [-scale #]
                    [-init (med|min)] [-sky (none|mode)]
                    [-sigmas #] [-radius #] [-thresh #]
                    [-pdq #]

input             comma-delimited string (e.g., filename or filename1,filename2,filename3)
output            string
-t                print timestamps
-v                turn on verbose mode
-shadcorr         turn on shutter shading correction (intended for CCD images only)
-crmask           flag CR-rejected pixels in the input files
-readnoise_only   use read noise and not Poission noise to create ERR array (intended for BIAS images)
-table filename   cosmic ray rejection table to use for default parameter values
-scale #          multiplicative factor (in percent) applied to noise
-init med|min     scheme for computing initial guess image (median or minimum)
-sky none|mode    scheme for computing sky levels to be subtracted (none:0.0 or mode:most frequently occurring value)
-sigmas #[,#...]  cosmic ray rejection thresholds, no. of thresholds are the no. of iterations
-radius #         radius (in pixels) to propagate the cosmic ray
-thresh #         cosmic ray rejection propagation threshold
-pdq #            data quality flag used for cosmic ray rejection
(astroconda3) nmiles@nathan:~$calacs.e
CALACS Version 10.0.0
syntax:  calacs.e [--help] [-t] [-s] [-v] [-q] [-r] [--version] [--gitinfo] [-1|--nthreads <N>] [--ctegen <1|2>] [--pctetab <path>] input

It would be ideal if we could standardized the commonly used command line arguments across all the underlying calacs.e executables, so that means each routine would have --help, -t, -s, -v, -q, --version, --gitinfo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants