HLA-1233: Updated configuration files to use fitgeom='rshift' and minobj=10 #1769
Conversation
s-goldman
added
enhancement
in progress
Do Not Merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1769 +/- ##
==========================================
- Coverage 34.47% 31.49% -2.99%
==========================================
Files 127 159 +32
Lines 31209 35139 +3930
Branches 5772 0 -5772
==========================================
+ Hits 10759 11066 +307
- Misses 19252 24073 +4821
+ Partials 1198 0 -1198 ☔ View full report in Codecov by Sentry. |
s-goldman
added
ready-for-final-review
and removed
Do Not Merge
…_minobj_10_03_13_24
…_minobj_10_03_13_24
…_minobj_10_03_13_24
…_minobj_10_03_13_24
|
Holding off on merging this until the instrument scientists have a chance to test the code. |
…_minobj_10_03_13_24
|
@s-goldman Please make sure Jenn and Rick know this code is available for testing -- tag them in this ticket or the JIRA ticket so they do not forget. |
|
I often forget to do this, but please ask Jenn for a dataset which you can test yourself and observe the differences with regard to the changes you have made. Perhaps you have already done this and just did not document the test here. If so, please ignore this comment. However, as noted above, please ask Jenn and/or Rick to do a test also. |
Resolves HLA-1233
Closes #1763
This PR updates the configuration files to use the 'rshift' fitgeom instead of 'rscale'. It also increases the minimum number of identified objects from each input image to use in matching objects from 6 to 10 for the default ('rshift') fitgeom. The fitgeom='shift' options has also been removed from the matrix of fits for HAP.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR
Jenkins test