Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for figures to load when first opened #164

Open
Rplesha opened this issue Apr 30, 2020 · 0 comments
Open

Allow for figures to load when first opened #164

Rplesha opened this issue Apr 30, 2020 · 0 comments

Comments

@Rplesha
Copy link

Rplesha commented Apr 30, 2020

Currently the plots all have visible=False automatically so that all of the layers aren't stacked on top of each other. This is slightly inconvenient when opening a plot, and should be able to be easily fixed by instead passing in the visible parameter as a variable and setting it to be True for the first trace that is called, and False for all of the rest.

For example, in osm_shift_monitors.py we could update:

  • Line 108 to read:
    def _plot_per_cenwave(self, df: pd.DataFrame, shift: str, outliers: pd.DataFrame = None, vis: bool = True) -> int: (I think, I still don't really understand this format)

  • Line 133 & Line 154 & Line 179 & Line 203 to read:
    visible=vis

  • Line 224 to read:
    all_n_traces = self._plot_per_cenwave(self.data, self.shift, outliers)

  • Line 237 to read:
    n_fp_traces = self._plot_per_cenwave(group, self.shift, outlier_group, vis=False)

This would then default to open the "All" trace when the plot is first opened up, rather than a blank plot. This could be different for different monitors to show what the most important button is in the top level trace.

@Rplesha Rplesha changed the title Allow for figures to load automatically Allow for figures to load when first opened Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant