Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DataModel for Dark monitors #157

Open
jwhite3 opened this issue Feb 14, 2020 · 1 comment · May be fixed by #156 or #73
Open

Create DataModel for Dark monitors #157

jwhite3 opened this issue Feb 14, 2020 · 1 comment · May be fixed by #156 or #73

Comments

@jwhite3
Copy link
Contributor

jwhite3 commented Feb 14, 2020

The Dark Monitors will likely require the same (or very similar) bits of data to perform the actual monitoring, so it makes sense to create one DataModel for all of the dark monitors to use.

@jwhite3 jwhite3 added this to the Add Dark Monitors milestone Feb 14, 2020
@jwhite3 jwhite3 added this to To do in COSMO Overhaul via automation Feb 14, 2020
@jwhite3
Copy link
Contributor Author

jwhite3 commented Feb 14, 2020

There seem to be a few options for doing this:

  1. Create a DataModel that pulls corrtag files directly from the dark monitor programs. This would ensure that the data remains focused on what's needed for the dark monitors and is much more efficient than looking through all available corrtag files across all programs, but it also means that whatever list that defines the dark monitor programs would need to be updated yearly.

  2. Create a CorrtagDataModel that's general to corrtag files, and then pull files with EXPTYPE = 'DARK'. This would avoid the issue of having to update the set of defined dark programs each year, but then there's the risk of the scope of this table becoming too large. There's currently no other monitor that requires data from corrtag files, so ingesting data from all COS corrtag files might be overkill.

  3. Run through all new corrtag files, but only ingest if the EXPTYPE = "Dark". This is inefficient, but not prohibitively so, especially since there'd only be a need to run through all corrtag files one time (the first time), and then the monitor would only need to look at a few at a time after that (assuming that it executes every few weeks or so). This has the benefit of avoiding updating the dark programs list while also keeping the scope of the DataModel well-defined

@cmagness cmagness linked a pull request Feb 14, 2020 that will close this issue
@dzhuliya dzhuliya linked a pull request Feb 14, 2020 that will close this issue
@jwhite3 jwhite3 moved this from To do to In progress in COSMO Overhaul Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
COSMO Overhaul
  
In progress
3 participants